-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyquil requirement from ~=3.5.4 to ~=4.11.0 #2063
base: main
Are you sure you want to change the base?
Conversation
2c34d4b
to
ffecf50
Compare
ffecf50
to
629dcdb
Compare
We'll have to wait for quantumlib/Cirq#6281 to land (and be released) before we can support pyquil 4. |
A newer version of pyquil exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
quantumlib/Cirq#6281 has landed. Will now just wait for a patch release. |
Patch release is out! https://github.com/quantumlib/Cirq/releases/tag/v1.4.1 |
3b0a1a5
to
6c07441
Compare
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
There are two pyquil conversion issue which are causing the Ubuntu builds to fail.
I've raised an issue for point 2 here: quantumlib/Cirq#6714. I haven't been able to reproduce locally a MRE for point 1 just yet, but if I can I will open a different issue. Since this isn't a huge concern for us I recommend we modify this test so it passes as is and add a note for ourselves to come back to it if cirq/pyquil fix the underlying issues. Only challenging thing here is that the issue only seems to be arising on Ubuntu. Another option is to intentionally skip this test for the time being just so we can upgrade the rest of the dependencies. |
We run those tests only on Ubuntu 😬 See mitiq/.github/workflows/build.yml Line 89 in 685e7d0
Lines 60 to 61 in 685e7d0
|
This is now blocked by the two pyquil tutorials. They are both failing with the same error relating to a "bug" that happens when converting a pyquil program to a cirq circuit. In short, when a pyquil program that has a scalar variable, say I've opened a PR quantumlib/Cirq#6755 with a partial fix, but it needs input to be taken further. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 89 90 +1
Lines 4131 4156 +25
=======================================
+ Hits 4078 4103 +25
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Description
upgrade support to pyquil v4
fixes #2254
Updates the requirements on pyquil to permit the latest version.
Release notes
Sourced from pyquil's releases.
Changelog
Sourced from pyquil's changelog.
... (truncated)
Commits
a72499c
chore: prepare release 4.0.3 [skip ci]314038c
chore: prepare release 4.0.3-rc.0 [skip ci]a73a896
fix: only rewrite arithmetic when targeting Aspen processors (#1679)ca07ff6
chore: prepare release 4.0.2 [skip ci]38f6d75
chore: prepare release 4.0.2-rc.0 [skip ci]f84445e
fix: update qcs-sdk-rust and quil-rs to pull in fixes (#1680)fdedda2
chore: prepare release 4.0.1 [skip ci]8b90d65
chore: prepare release 4.0.1-rc.0 [skip ci]fc513ea
fix:Gate
s should no longer compare as equal and not equal. (#1671)3a6b057
re-enable knope changelog management (#1662)Most Recent Ignore Conditions Applied to This Pull Request
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)